Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors out if creation time not supported #21

Closed
jgreenbaum opened this issue Sep 12, 2024 · 3 comments · Fixed by #25
Closed

Errors out if creation time not supported #21

jgreenbaum opened this issue Sep 12, 2024 · 3 comments · Fixed by #25
Assignees
Labels
bug Something isn't working

Comments

@jgreenbaum
Copy link

Describe the bug

binsider fails to load an elf file from a file system that doesn't support creation. Instead it reports the error "IO error: creation time is not available for the filesystem"

To reproduce

Run binsider with a file argument on a file system without ctime support, like an NFS mount or tmpfs.

Expected behavior

binsider should load the elf file, but not display a creation time

Software information

  • Operating system: RHEL 8
  • Rust version: 1.77.2
  • Project version: HEAD

Additional context

I worked around it by modifying src/file.rs to set FileDateInfo.birth to "".into() if metadata.created().is_err(). You might want to implement something different.

@orhun
Copy link
Owner

orhun commented Sep 13, 2024

Thanks for the report and sharing your workaround!

Added a fix here: #25

Do you think there might be other edge cases where e.g. modify or change time is not supported as well? Should we take measures for them as well?

@sassman
Copy link

sassman commented Sep 16, 2024

I ran into the same issue by running it on docker from an apple silicone machine

❯ docker run --platform linux/amd64 -v ${PWD}:/mnt -w /mnt --rm -it ubuntu:latest /bin/bash

@orhun orhun closed this as completed in #25 Sep 17, 2024
@orhun
Copy link
Owner

orhun commented Sep 18, 2024

Going to be fixed with the upcoming release :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants