Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oro mysql privileges check not compatible with Sentry TracingServerInfoAwareDriverConnection #1077

Open
Janvdv opened this issue Dec 22, 2021 · 0 comments

Comments

@Janvdv
Copy link

Janvdv commented Dec 22, 2021

Summary
While upgrading oro-platform from 4.2.3 to 4.2.7 we encountered an error during oro:platform:update:

Steps to reproduce
install these packages
"oro/platform": "4.2.7"
"sentry/sentry-symfony": "^4.2.2",
"sentry/sentry": "^3.3",

Actual Result

  [Symfony\Component\Debug\Exception\FatalThrowableError]                                                                                                                                                                                                                
  Oro\Component\DoctrineUtils\DBAL\DbPrivilegesProvider::getMySqlGrantedPrivileges(): Argument #1 ($pdo) must be of type Doctrine\DBAL\Driver\PDO\Connection, Sentry\SentryBundle\Tracing\Doctrine\DBAL\TracingServerInfoAwareDriverConnection given, called in /var/ww  
  w/html/vendor/oro/platform/src/Oro/Bundle/InstallerBundle/Provider/MysqlDatabaseRequirementsProvider.php on line 57

Expected Result
No Errors

I suspect the typehint for $pdo here should be changed to Doctrine\DBAL\Driver\Connection

Details about your environment

  • OroPlatform version: 4.2.7
  • PHP version: 8.0.8
  • Database MySQL 8.0.25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant