Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Activation keys race condition #2961

Open
lucasgarfield opened this issue Mar 5, 2025 · 0 comments
Open

Activation keys race condition #2961

lucasgarfield opened this issue Mar 5, 2025 · 0 comments
Assignees
@ksiekl
Labels
🐞 bug Something isn't working

Comments

@lucasgarfield
Copy link
Collaborator

The activation key’s API is slow. It is possible to move past the “optional” activation keys step while an activation key is being fetched.

Steps to reproduce:

  1. Open the Image Builder wizard, quickly select a target, click ‘Next’, click ‘Next’ again, then go to the review step.
  2. Click "Create Blueprint". Nothing will happen. Presumably this is because there is no activation key.

Resolution:
If a user somehow makes it to the Review step without an activation key having been fetched, there should be an error displayed in the navigation bar alerting them to revisit the activation key step and the "Create blueprint" button should be disabled.

One possible way to do fix this might be to ensure that the in-flight activation key request can still land regardless of which step the wizard is on.
@lucasgarfield lucasgarfield added the 🐞 bug Something isn't working label Mar 5, 2025
ksiekl added a commit to ksiekl/image-builder-frontend that referenced this issue Mar 12, 2025
@ksiekl
Wizard: race condition with activation key
7da811a 
Fixes osbuild#2961

The "Create blueprint" button is disabled if an activation key was not created in the Review step of the wizard.
ksiekl added a commit to ksiekl/image-builder-frontend that referenced this issue Mar 12, 2025
@ksiekl
Wizard: disable Review and finish button until an activation key loads.
41534ae 
Fixes osbuild#2961

If an activation key was not created and the user didn't check the option to register later, don't allow them to skip to the Review step.
ksiekl added a commit to ksiekl/image-builder-frontend that referenced this issue Mar 17, 2025
@ksiekl
Wizard: load activation key in the review step
e632e5d 
Fixes osbuild#2961

Activation key loads in background even if a user skips to the review step.
lucasgarfield pushed a commit to ksiekl/image-builder-frontend that referenced this issue Mar 17, 2025
@ksiekl @lucasgarfield
Wizard: race condition with activation key
35074a3 
Fixes osbuild#2961

The "Create blueprint" button is disabled if an activation key was not created in the Review step of the wizard.
lucasgarfield pushed a commit to ksiekl/image-builder-frontend that referenced this issue Mar 17, 2025
@ksiekl @lucasgarfield
Wizard: load activation key in the review step
ed7ce58 
Fixes osbuild#2961

Activation key loads in background even if a user skips to the review step.
ksiekl added a commit to ksiekl/image-builder-frontend that referenced this issue Mar 19, 2025
@ksiekl
Wizard: race condition with activation key
02313ca 
Fixes osbuild#2961

The "Create blueprint" button is disabled if an activation key was not created in the Review step of the wizard.

Wizard: load activation key in the review step

Fixes osbuild#2961

Activation key loads in background even if a user skips to the review step.

Wizard: leave Save button in review step enabled

Wizard: disable Save button in review step for Rhel distro only

Wizard: enable "Create blueprint" button on prem.
lucasgarfield pushed a commit to ksiekl/image-builder-frontend that referenced this issue Mar 19, 2025
@ksiekl @lucasgarfield
Wizard: race condition with activation key
1cd58fe 
Fixes osbuild#2961

The "Create blueprint" button is disabled if an activation key was not created in the Review step of the wizard.

Wizard: load activation key in the review step

Fixes osbuild#2961

Activation key loads in background even if a user skips to the review step.

Wizard: leave Save button in review step enabled

Wizard: disable Save button in review step for Rhel distro only

Wizard: enable "Create blueprint" button on prem.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ksiekl ksiekl

Labels
🐞 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ksiekl @lucasgarfield