osbuild: update org.osbuild.systemd.unit.create stage #1191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The struct for these options is named MountSection because Mount is already defined for osbuild Mount modules.
Rename all the types that are used for systemd.unit.create stage options for consistency.
Split the stage option validation based on the filename extension and validate each separately.
The SystemdUnit type holds options for all unit types: service, mount, and socket. Rename it from SystemdServiceUnit so that it doesn't imply only one of the three is supported.
achilleas-k
force-pushed
the
update/systemd.unit.create
branch
from
ef0299c to
e8310ec
Compare
supakeen
approved these changes
Feb 4, 2025
thozza
approved these changes
Feb 5, 2025
There was a problem hiding this comment.
Thanks.
We should really somehow mark the minimum osbuild version for images version, to not generate manifests that will fail with old osbuild and also auto-detect (by some kind of test) in all places that use images, that we need to bump the dependency in the SPEC.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the org.osbuild.systemd.unit.create stage to match the options in osbuild, especially the new sections for mount and socket unit types.
Tests added to cover all validation failures.