tools: use go toolbox instead of installing a binary #4600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achilleas-k
force-pushed
the
tools/prepare-source/update-again
branch
from
e13e4f2 to
0292a13
Compare
|
Rebased on main and updated commit ID for the revert in the commit message. |
bcl
previously approved these changes
Feb 6, 2025
achilleas-k
force-pushed
the
tools/prepare-source/update-again
branch
from
0292a13 to
d0490ad
Compare
achilleas-k
requested review from
mvo5,
schuellerf and
bcl
and removed request for
a team
lzap
reviewed
Feb 7, 2025
lzap
previously approved these changes
Feb 7, 2025
There was a problem hiding this comment.
Yeah I really hope this will work, cos once we update to 1.24 with its tool version fix that will be a complete and hassle-free experience, finally!
ezr-ondrej
force-pushed
the
tools/prepare-source/update-again
branch
from
7b317f4 to
3e4187b
Compare
achilleas-k
force-pushed
the
tools/prepare-source/update-again
branch
from
3e4187b to
db881ef
Compare
achilleas-k
force-pushed
the
tools/prepare-source/update-again
branch
from
db881ef to
d7a7481
Compare
|
Had to downgrade to Go 1.22.11 because Fedora 40 doesn't have .12 |
achilleas-k
force-pushed
the
tools/prepare-source/update-again
branch
from
d7a7481 to
19b51fd
Compare
Repeat of 8554d62. This is a much nicer (and newer) way of handling the Go version for the project. The issue that caused the previous revert was that the toolbox version was being set to 1.22.0, which is older than what some dependencies require, specifically osbuild/images, so the 'go mod tidy' would downgrade images to match the required toolbox version. Setting the go and toolbox version to 1.22.6 should make it all work as expected. This reverts commit 7e87d1e. Co-authored-by: Lukáš Zapletal <[email protected]>
Use endoflife.date to check for newer versions of the minor Go version we're using and print a notice.
achilleas-k
force-pushed
the
tools/prepare-source/update-again
branch
from
19b51fd to
2b56e8a
Compare
|
I dropped the last commit that updates the Go version. We still have RHEL 8.10 and 9.4 RPM builds going on here, so let's just get the new script in and look at distro and compiler versions separately. |
lzap
approved these changes
Feb 13, 2025
thozza
approved these changes
Feb 17, 2025
achilleas-k
added a commit
to achilleas-k/images
that referenced
this pull request
Feb 17, 2025
Running ./tools/prepare-source.sh in osbuild-composer now requires jq for the version check. osbuild/osbuild-composer#4600
achilleas-k
added a commit
to achilleas-k/images
that referenced
this pull request
Feb 17, 2025
Running ./tools/prepare-source.sh in osbuild-composer now requires jq for the version check. osbuild/osbuild-composer#4600
github-merge-queue bot
pushed a commit
to osbuild/images
that referenced
this pull request
Feb 18, 2025
Running ./tools/prepare-source.sh in osbuild-composer now requires jq for the version check. osbuild/osbuild-composer#4600
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repeat of 8554d62.
This is a much nicer (and newer) way of handling the Go version for the
project. The issue that caused the previous revert was that the toolbox
version was being set to 1.22.0, which is older than what some
dependencies require, specifically osbuild/images, so the 'go mod tidy'
would downgrade images to match the required toolbox version.
Setting the go and toolbox version to 1.22.6 should make it all work as
expected.
This reverts commit 7e87d1e.
Co-authored-by: Lukáš Zapletal [email protected]