Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bun build --compile leads to .bun-build workspace clutter #14020

Open
jeremybanka opened this issue Sep 18, 2024 · 3 comments
Open

bun build --compile leads to .bun-build workspace clutter #14020

jeremybanka opened this issue Sep 18, 2024 · 3 comments
Labels
bug Something isn't working bundler Something to do with the bundler good first issue Something that would be good for new contributors

Comments

@jeremybanka
Copy link

jeremybanka commented Sep 18, 2024

What version of Bun is running?

1.1.28+cf4e9cb69

What platform is your computer?

Darwin 24.0.0 arm64 arm

What steps can reproduce the bug?

It seems calling bun bulld --compile on any valid file will do, but for example:

echo 'console.log("Hi!")' >> main.js
bun build main.js --compile

Now, you will see the following files in your directory:

.17f66bb7eff7fbbd-00000000.bun-build # for example
main
main.js

.17f66bb7eff7fbbd-00000000.bun-build seems to be a temp file or build artifact of some kind. I don't know what it is. Deleting it has no bearing on soundness of the final binary, main.

What is the expected behavior?

No .bun-build files left behind in my workspace that I need to deal with.

What do you see instead?

A burgeoning pile of .bun-build files in my workspace.

I have to remove them constantly

So I'll keep a post-build script that deletes these as they pile up.

find . -maxdepth 1 -type f -name '*.bun-build' -exec rm -v {} \;

I kept accidentally checking them in

So I need to keep a pattern for them in my .gitignore

*.bun-build

Additional information

No response

@jeremybanka jeremybanka added bug Something isn't working needs triage labels Sep 18, 2024
@Jarred-Sumner
Copy link
Collaborator

Hm it's supposed to delete this

@jeremybanka
Copy link
Author

Hm it's supposed to delete this

I would have thought so, is there any debug output I can find and share?

@paperdave
Copy link
Member

this function is not well written.

image

it defines a cleanup function which is supposed to cleanup temporary information, but does not properly place it at all exit points.

the zig language has a feature to prevent these mistakes: defer. this code shouldnt just exit the process on failure and instead return an error so that proper cleanup happens. this is also why #6249 isnt implemented; any errors would interrupt the entire program instead of a JS exception

@paperdave paperdave added bundler Something to do with the bundler good first issue Something that would be good for new contributors and removed needs triage labels Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working bundler Something to do with the bundler good first issue Something that would be good for new contributors
Projects
None yet
Development

No branches or pull requests

3 participants