Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 14037 #14047

Merged
merged 3 commits into from
Sep 19, 2024
Merged

fix 14037 #14047

merged 3 commits into from
Sep 19, 2024

Conversation

dylan-conway
Copy link
Collaborator

@dylan-conway dylan-conway commented Sep 19, 2024

What does this PR do?

fixes #14037
fixes #13748
fixes #13398
fixes #10873
fixes #13582
fixes #13522
fixes #13183

How did you verify your code works?

added a test for importing wasm in a bundle

Copy link
Member

@paperdave paperdave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

@@ -684,6 +684,8 @@ pub const Loader = enum(u8) {
.napi,
.sqlite,
.sqlite_embedded,
// TODO: loader for reading bytes and creating module or instance
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changing the default behavior of a loader after implementing is a breaking change. so implementing this todo would be a separate loader. like we could do with { type: 'wasm' }. not important now.

@dylan-conway dylan-conway merged commit cff7b98 into main Sep 19, 2024
45 of 46 checks passed
@dylan-conway dylan-conway deleted the dylan/fix-14037 branch September 19, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment