faiss-napi package segfault from version 1.2.2 to 1.2.5

[asilvas-godaddy]

How can we reproduce the crash?

Reverting to version 1.2.1 was required to stop crash.

Relevant log output

Bun v1.2.5 (013fdddc) macOS Silicon
macOS v14.7.4
Args: "bun" "scripts/build-integrations.ts"
Features: Bun.stderr(4) Bun.stdin(2) Bun.stdout(4) fetch(4) jsc transpiler_cache(5) tsconfig(5) workers_spawned napi_module_register process_dlopen 
Builtins: "abort-controller" "bun:jsc" "bun:main" "node:assert" "node:buffer" "node:child_process" "node:crypto" "node:events" "node:fs" "node:fs/promises" "node:http" "node:https" "node:module" "node:os" "node:path" "node:process" "node:querystring" "node:stream" "node:string_decoder" "node:tty" "node:url" "node:util" "node:util/types" "node:worker_threads" "node-fetch" "node:v8" "node:http2" 
Elapsed: 1417ms | User: 408ms | Sys: 126ms
RSS: 0.18GB | Peak: 0.18GB | Commit: 0.90GB | Faults: 59

Stack Trace (bun.report)

Bun v1.2.5 (013fddd) on macos aarch64 [AutoCommand]

Segmentation fault at address 0x00000018

• 6 unknown/js code
• long long Zig::NapiClass_ConstructorFunction<false>
• 1 unknown/js code
• jsc_llint_commonCallOp__llintOpWithMetadata__llintOpWithReturn__llintOp__commonOp__fn__fn__makeReturn__fn__fn__fn__684_callHelper__dispatch_LowLevelInterpreter64_asm_2535
• llint_call_javascript

Features: transpiler_cache, tsconfig, workers_spawned, napi_module_register, process_dlopen, Bun.stderr, Bun.stdin, Bun.stdout, fetch, jsc

[github-actions]

Thank you for reporting this crash.

For Bun's internal tracking, this issue is BUN-E2H.

[Electroid]

We rewrote a large chunk of N-API in 1.2.5, @190n could you take a look?

[Electroid]

@asilvas-godaddy Is it possible to share some code so it's easier for us to reproduce?

[190n]

I tried running the example code in the faiss-napi README, and I do get a C++ exception:

panic(main thread): A C++ exception occurred

But the same thing happens in Node, too:

libc++abi: terminating due to uncaught exception of type faiss::FaissException: Error in virtual void faiss::IndexIVFFlat::add_core(idx_t, const float *, const int64_t *, const int64_t *) at /Users/runner/work/faiss-node/faiss-node/deps/faiss/faiss/IndexIVFFlat.cpp:51: Error: 'is_trained' failed

I would love to see a code example that reproduces the segfault if you can share one.

Also, do versions 1.2.3 and 1.2.4 have this segfault?

[asilvas-godaddy]

Having a hard time trying to provide an isolated repro code, but I'll keep trying.

Yes versions 1.2.2, 1.2.3, 1.2.4, 1.2.5 all had the same issue. Exceptions are not the concern unless those exceptions are resulting in the segfault.