Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import 60400f956e: Updated hifi-glyphs with tivoli icons (by Maki) #423

Open
daleglass opened this issue Aug 5, 2022 · 1 comment
Open
Labels
automanaged Managed by a bot. Title and body are overwritten. Tags may be modified. Tivoli: Discard This commit isn't useful to our project

Comments

@daleglass
Copy link

This is an automated proposal to look at a commit made by Maki and import it into Overte

Commit: 60400f9
Author: Maki
Date: Tue, 05 May 2020 19:40
Updated hifi-glyphs with tivoli icons

Stats:

Filename Stats Lines Added Removed Lines in blame
interface/resources/fonts/hifi-glyphs-1.38/fonts/hifi-glyphs.eot 0 0 0 ⚠ File gone
interface/resources/fonts/hifi-glyphs-1.38/fonts/hifi-glyphs.svg 0 0 0 ⚠ File gone
interface/resources/fonts/hifi-glyphs-1.38/fonts/hifi-glyphs.ttf 0 0 0 ⚠ File gone
interface/resources/fonts/hifi-glyphs-1.38/fonts/hifi-glyphs.woff 0 0 0 ⚠ File gone
interface/resources/fonts/hifi-glyphs-1.38/icons-reference.html 1256 0 1256 ⚠ File gone
interface/resources/fonts/hifi-glyphs.ttf 0 0 0 326
interface/resources/fonts/hifi-glyphs/README.md 3 3 0 3
interface/resources/fonts/hifi-glyphs/hifi-glyphs.old.sfd 9758 9758 0 9758
interface/resources/fonts/hifi-glyphs/hifi-glyphs.sfd 8824 8824 0 8759
interface/resources/fonts/{hifi-glyphs-1.38 => hifi-glyphs}/styles.css 10 3 7 ⚠ File gone
scripts/system/html/fonts/hifi-glyphs.ttf 0 0 0 326
unpublishedScripts/marketplace/record/html/fonts/hifi-glyphs.ttf 0 0 0 440
12 files - 19851 18588 1263 19612

To work on this, please assign the issue to yourself, then look at the commit and decide whether this would be a good addition to Overte.

  • If the commit is useful, tag it with "Tivoli: Keep", and keep it open until it's merged.
  • If the commit is not useful, tag it with "Tivoli: Discard", and close it.
  • If the commit is not useful right now, but might be later, tag it with "Tivoli: Maybe later", and close it.
  • If it's hard to decide, tag it with "Tivoli: Discuss", and keep it open.

Useful commits should be submitted as a PR against Overte. Tag this issue in PR, so that it's automatically closed once the PR is merged.

You can cherry-pick this issue with this command:

git cherry-pick 60400f956edce3cbd5ec4284391800aad85c6f2f
@daleglass daleglass added the automanaged Managed by a bot. Title and body are overwritten. Tags may be modified. label Aug 5, 2022
@AleziaKurdis
Copy link

Hum... Careful with this. Make sure to compare the fonts. (I'm quite sure that I never changed it, I created a Vircadia-glyph font for new icons, but just in case, to make sure it doesn't regress)

If this is only for a tivoli logo I don't think we need this.

In any case, if we need to edit the font, we don't need all those extra files...
just using this editor: https://www.glyphrstudio.com/online/
and this converter: https://cloudconvert.com/otf-to-ttf
and make sure to do things clean.

If we need new icons, I wopuld recommend to create an gverte-glyph font anyway.

@daleglass daleglass added the Tivoli: Discard This commit isn't useful to our project label Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automanaged Managed by a bot. Title and body are overwritten. Tags may be modified. Tivoli: Discard This commit isn't useful to our project
Projects
None yet
Development

No branches or pull requests

2 participants