Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA] enable SEND_SCENARIO_LINE_REFERENCES by default and do not pass xRequestId param #11067

Open
2 tasks
saw-jan opened this issue Feb 26, 2025 · 0 comments
Open
2 tasks
Labels

Comments

@saw-jan
Copy link
Member

saw-jan commented Feb 26, 2025

env SEND_SCENARIO_LINE_REFERENCES is used to enable and disable the generation of scenario line as the HTTP request id. We should make this true by default and even maybe remove the env.

Almost all the methods accept xRequestId param but having it as a method param can lead it to be empty if we forget to pass it. So, the better implementation would be to store the current scenario ref and use it in the guzzle request object directly. And then we can remove the param from all methods. This also makes sure that every request has a defined request id.

TODO:

  • remove SEND_SCENARIO_LINE_REFERENCES and enable it by default
  • use saved xRequestId directly in the guzzle request object.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant