Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible bug in KKT equilibration #153

Open
goulart-paul opened this issue Mar 15, 2022 · 0 comments
Open

Possible bug in KKT equilibration #153

goulart-paul opened this issue Mar 15, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@goulart-paul
Copy link
Member

A possible bug in the equilibration procedure. I am not certain that this is a bug because it depends on whether the P matrix can be only upper (or lower) triangular when equilibrating. The problem is this:

  • Suppose that P == triu(P) inside the ruiz scaling procedure.
  • The functions calls kkt_col_norms! here.
  • That function in turn calls col_norms! here, where the col_norms! function itself does not seem to check if a matrix is represented only by its upper or lower triangle.

if this is a real problem then I can fix with a PR since I fixed it already in a different package. Whether it is necessary depends on whether P is guaranteed to be fully symmetric or not.

@goulart-paul goulart-paul added the bug Something isn't working label Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant