No arch dependencies (such as jar files) should not be filtered out

[anthonydahanne]

With the support for dual arch, such filters were added:

https://github.com/paketo-buildpacks/libpak/blob/620bd46eb3bf74d4af08246b0815bd0589e53f7b/buildpack.go#L511C1-L518C4

Now, I'm running tests for spring-boot buildpack currently, and my system arch is arm64

During my test run, I'm asserting Spring-Cloud-Bindings jar is downloaded, but because of:

	        // filter out deps that do not match the current running architecture
		arch, err := archFromPURL(c.PURL)

no PURL was given, so it defaults to amd64

		if err != nil {
			return BuildpackDependency{}, fmt.Errorf("unable to compare arch\n%w", err)
		}
		if arch != archFromSystem() {
			continue
		}

and now my dependency is skipped

I'm no longer sure what the best course of action is:

• configure tests with a dynamic PURL that would adapt to the machine running the tests (ends with arch=arm64 if the tests run on arm64)
• default arch in the piece of code above to empty string and if it's empty string, then consider the dependency to be resolved on all arch.
• do nothing and wait for the proper detection mechanism for arch (Implement RFC 0059 - Update metadata to be consistent with RFC standard #327)

[anthonydahanne]

To have my tests passing, I simply added:

purl = "pkg:generic/springframework/[email protected]"

to the test setup, for my dependency; because if the purl is not empty, archFromSystem() will take the OS arch

[dmikusa]

I'm going to close this out because I think it's working as designed at the moment. You need to have something in the PURL and for reference, if anyone else sees this issue, #335 (comment) is what you should add.

Also, we're hopefully going to have #327 implemented soon and that should clear up some of this as well.