Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pd.RangeIndex should accept range as the first argument #677

Closed
Daverball opened this issue May 3, 2023 · 2 comments · Fixed by #1005
Closed

pd.RangeIndex should accept range as the first argument #677

Daverball opened this issue May 3, 2023 · 2 comments · Fixed by #1005
Labels
good first issue Index Related to the Index class or subclasses

Comments

@Daverball
Copy link
Contributor

Describe the bug
Both according to the docs and the implementation it is valid to pass a python range object as the first argument to pd.RangeIndex

To Reproduce

import pandas as pd

pd.RangeIndex(range(5))  # mypy: arg-type – Argument 1 to "RangeIndex" has incompatible type "range"

Please complete the following information:

  • OS: Linux (OpenSUSE Tumbleweed)
  • Python 3.10
  • mypy 1.0.1
  • pandas-stubs 2.0.1.230501
@twoertwein
Copy link
Member

Would need to add range here

pandas-stubs/pandas-stubs/core/indexes/range.pyi

Line 30 in 9c301b3

start: int | RangeIndex = ...,
(and probably also for __new__)

@Dr-Irv
Copy link
Collaborator

Dr-Irv commented May 5, 2023

(and probably also for __new__)

We actually don't need __new__() here, so we should delete it.

@Dr-Irv Dr-Irv added the Index Related to the Index class or subclasses label May 5, 2023
@kshitiz305 kshitiz305 mentioned this issue May 7, 2023
Closed
2 tasks
@loicdiridollou loicdiridollou mentioned this issue Sep 22, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Index Related to the Index class or subclasses
Projects
None yet
Milestone
No milestone
3 participants
@Daverball @twoertwein @Dr-Irv