Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Add HalfYear offsets #60946

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

ENH: Add HalfYear offsets #60946

wants to merge 2 commits into from
+943 −2

Conversation

snitish
Copy link
Contributor

@snitish snitish commented Feb 17, 2025

@snitish snitish marked this pull request as draft February 17, 2025 02:28
@snitish
Copy link
Contributor Author

snitish commented Feb 17, 2025 •
edited
Loading

@rhshadrach I was able to add the half-year offset classes without too much added complexity. However, I haven't enabled them to be used as periods - that will take more code changes and tests. Do you recommend concluding this here or go all the way to supporting half-year periods? cc: @MarcoGorelli

rwijtvliet
rwijtvliet reviewed Feb 17, 2025
View reviewed changes
Copy link

@rwijtvliet rwijtvliet left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great sofar to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwijtvliet rwijtvliet rwijtvliet left review comments

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ENH: Control resampling at halfyear with origin Add "semester" as a time/date component to DatetimeIndex
2 participants
@snitish @rwijtvliet