-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub Actions Configuration #204
Comments
Could also utilize some newer github actions, such as:
|
copying some discussion from #282 The miniforge version is currently specified in a couple places, because of how we generate a lockfile for every PR via github actions. pangeo-docker-images/.github/workflows/CondaLock.yml Lines 37 to 44 in 9b282f5
I think a better strategy going forward might be to install |
The GitHub Actions in the repository are fairly complex, mainly stemming from the fact that we want to add environment lock files from any PR. But PRs coming from forks only have read access by default, which is why we use our pangeo-bot user access token and /slash commands to have write access.
I recently learned a lot from this blog post https://securitylab.github.com/research/github-actions-preventing-pwn-requests/ on best practices for structuring this style of CI. Likely could make some modifications and improvements to how things are currently structured.
The text was updated successfully, but these errors were encountered: