-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dask proxy to labextension.yaml #253
Comments
Thanks @lsterzinger , let's wait on a pull request because i think there might be a few approaches. Ideally, the reported dashboard url would be functional for both a LocalCluster and GatewayCluster. So instead of overriding the global dashboard config link, we'd only want to do this for LocalClusters. @TomAugspurger seems |
@consideRatio @ian-r-rose there seem to be a lot of related issues discussed over in the dask-labextension repository (e.g. dask/dask-labextension#41) but i'm not tacking down a relevant |
It seems to me like setting So maybe it's OK to just change that setting? I'm not sure how the dask-gateway URL is determined, but it doesn't seem to be harmed by setting it. |
Is setting that parameter from within the notebook the same as writing to the config file like I did during the docker image build stage? |
Setting it in the notebook was just for illustration, but yes, it's equivalent. IMO, this shouldn't be set here in pangeo-docker-images. I think it should be set wherever the image is being used (e.g. https://github.com/pangeo-data/pangeo-cloud-federation) |
It'd be nice if the pangeo notebook dask-labextension knew to use the
/proxy/localhost:8787
option by default, since as @scottyhq mentioned in Gitter it's probably more common to be running a LocalCluster rather than a GatewayCluster.Right now, I'm able to append:
To
~/.config/dask/labextension.yaml
view the line:in my Dockerfile, and confirmed it worked in pangeo binder. I can open a PR to add this to one of Pangeo dockerfiles, but I'm not sure which one.
base-image
?The text was updated successfully, but these errors were encountered: