Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Will IntelliSense for styles be supported? #156

Open
patrulea opened this issue May 8, 2023 · 5 comments
Open

Will IntelliSense for styles be supported? #156

patrulea opened this issue May 8, 2023 · 5 comments
Labels
⚡Enhancement New feature or request

Comments

@patrulea
Copy link

patrulea commented May 8, 2023

Syntax highlighting works as expected in suffixed stylesheets and within {% stylesheet %}/<style> regions, but will IntelliSense and validation come to future releases or Liquify?

I saw it working in one comment from @panoply in 2021: #56 (comment)

I’m on 4.0 RC.

@panoply
Copy link
Owner

panoply commented May 11, 2023

Hey @patrulea

Awesome to see you on 4.0 RC already. I can make it available in the official, was going to hold off until Liquify but if there is a need for it, I am happy to implement. Would need feedback on it,

@panoply panoply added the ⚡Enhancement New feature or request label May 11, 2023
@panoply
Copy link
Owner

panoply commented May 18, 2023

@patrulea I'll try get this out over weekend. Would you be able to test?

@patrulea
Copy link
Author

I’m ready 🫡

@panoply
Copy link
Owner

panoply commented May 18, 2023

I'll ping you when the v4 VSIX in next branch is ready and you can just reinstall. Things should work as expected. It's a good idea to periodically check the commits in #138 because I am publishing all the final refinements and ironing out any issues occuring.

Feedback is always appreciated too in the current RC and any bugs/errors you might be encountering is a huge help given you are already leveraging the latest (only a few users are as bleeding edge as us) ;)

panoply added a commit that referenced this issue May 18, 2023
@patrulea
Copy link
Author

patrulea commented Jun 1, 2023

IntelliSense and syntax highlighting for CSS and JavaScript work just fine within <style> and <script> tags but validation is totally absent.

Though, writing @define-mixins (custom syntax provided by post-css-mixins) breaks IntelliSense and syntax highlighting for the rest of the Liquid code in the file. I use an extension for the PostCSS language and recognize and validate this syntax in dedicated .css and .pcss files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚡Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants