Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Bundle inside BundleItem #44

Open
ghost opened this issue Dec 6, 2023 · 3 comments
Open

Add support for Bundle inside BundleItem #44

ghost opened this issue Dec 6, 2023 · 3 comments

Comments

@ghost
Copy link

ghost commented Dec 6, 2023

What's the reason that mev-share-rs doesn't support using Bundle as a BundleItem?

I see that MEV-Share supports this.

pub enum BundleItem {
    /// The hash of either a transaction or bundle we are trying to backrun.
    Hash {
        /// Tx hash.
        hash: TxHash,
    },
    /// A new signed transaction.
    #[serde(rename_all = "camelCase")]
    Tx {
        /// Bytes of the signed transaction.
        tx: Bytes,
        /// If true, the transaction can revert without the bundle being considered invalid.
        can_revert: bool,
    },
}
@SkandaBhat
Copy link

@mattsse This should be implemented in alloy too, correct? mev_simBundle requires this: https://github.com/flashbots/mev-share/blob/main/specs/bundles/v0.1.md

@mattsse
Copy link
Collaborator

mattsse commented Oct 2, 2024

yeah I think we could actually move all of these types into the alloy mev crate:

https://github.com/paradigmxyz/mev-share-rs/blob/main/crates/mev-share-sse/src/types.rs

@SkandaBhat
Copy link

Bundle has been added to BundleItem on alloy: alloy-rs/alloy#1418 Should it be added in this repo as well? @mattsse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants