Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crates/net: resolve_external_ip() fails silently, should error or panic #11026

Open
garwahl opened this issue Sep 19, 2024 · 0 comments
Open

crates/net: resolve_external_ip() fails silently, should error or panic #11026

garwahl opened this issue Sep 19, 2024 · 0 comments
Labels
A-networking Related to networking in general A-observability Related to tracing, metrics, logs and other observability tools

Comments

@garwahl
Copy link
Contributor

garwahl commented Sep 19, 2024

Currently when attempting to resolve an external IP address fails, we discard the error and fail silently. Instead we should log an error or panic.

ref: #10922 (comment)_ cc @emhane

I will pick this up. Whatever we do in #10922 we will duplicate here
@emhane emhane added A-observability Related to tracing, metrics, logs and other observability tools A-networking Related to networking in general labels Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-networking Related to networking in general A-observability Related to tracing, metrics, logs and other observability tools
Projects
Reth Tracker
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@garwahl @emhane