Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test coverage for 4844 rlp transactions #11032

Closed
mattsse opened this issue Sep 19, 2024 · 1 comment · Fixed by #11058
Closed

Improve test coverage for 4844 rlp transactions #11032

mattsse opened this issue Sep 19, 2024 · 1 comment · Fixed by #11058
Labels
C-enhancement New feature or request C-test A change that impacts how or what we test D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Sep 19, 2024

Describe the feature

we're lacking a few rlp tests for pooled 4844 transactions, which would have caught:

#11031

getting raw blob transactions isn't trivial because blobs are deleted...
blob transactions can be fetched from https://api.blobscan.com/

this could be helpful: https://github.com/foundry-rs/block-explorers/tree/main/crates/blob-explorers

TODO

  • get valid encoded 4844 with sidecar
  • and additional roundtrip tests

Additional context

No response

@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled D-good-first-issue Nice and easy! A great choice to get started C-test A change that impacts how or what we test and removed S-needs-triage This issue needs to be labelled labels Sep 19, 2024
@aroralanuk
Copy link
Contributor

Can I pick this one up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement New feature or request C-test A change that impacts how or what we test D-good-first-issue Nice and easy! A great choice to get started
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants