Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused dep nom #1175

Merged
merged 4 commits into from
Feb 12, 2025
Merged

chore: remove unused dep nom #1175

merged 4 commits into from
Feb 12, 2025

Conversation

de-sh
Copy link
Contributor

@de-sh de-sh commented Feb 8, 2025

Fixes #XXXX.

Description

These are dependencies that have been verified to be not in use anymore(neither with default nor with kafka) and can be safely removed.


This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

Summary by CodeRabbit

  • Chores
    • Performed maintenance on internal dependency configurations to enhance the build process and ensure greater project stability. An unused dependency was removed and the order of certain feature dependencies was reorganized, streamlining internal operations while maintaining the same user experience.

@de-sh de-sh changed the title chore: remove unused deps chore: remove unused dep nom Feb 8, 2025
Copy link

coderabbitai bot commented Feb 12, 2025

Walkthrough

The pull request modifies the Cargo.toml file for the Rust package "parseable." It removes the nom = "7.1.3" dependency and changes the order of dependencies under the kafka feature. These alterations adjust the dependency resolution order during compilation without changing the overall functionality of the package.

Changes

File Change Summary
Cargo.toml Removed nom = "7.1.3" dependency and reordered the kafka feature's dependencies (moved rdkafka related entries before sasl2-sys).

Poem

I hopped into the code today,
Found changes dancing in a neat array.
Nom was burrowed away with care,
And Kafka's parts now hop in a new flair.
With twitching whiskers, I cheer the shift—
A playful change that's truly swift! 🥕🐇


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 59a82d2 and 1d7346b.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • Cargo.toml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
  • GitHub Check: Build Kafka x86_64-unknown-linux-gnu
  • GitHub Check: Quest Smoke and Load Tests for Distributed deployments
  • GitHub Check: coverage
  • GitHub Check: Quest Smoke and Load Tests for Standalone deployments
🔇 Additional comments (2)
Cargo.toml (2)

10-124: LGTM! Removing unused dependency.

The removal of the unused nom dependency aligns with best practices of keeping dependencies minimal, which helps reduce the attack surface and improve maintainability.


147-147: LGTM! Improved dependency organization.

The reordering of dependencies under the kafka feature improves readability by grouping related dependencies together (rdkafka and its features, followed by sasl2-sys and its feature).


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@nitisht nitisht merged commit 20e66a4 into parseablehq:main Feb 12, 2025
12 of 14 checks passed
@de-sh de-sh deleted the deps branch February 12, 2025 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants