perf: save on clone cost during ingestion

[de-sh]

Fixes #XXXX.

Description

Removes an unnecessary step that merely clones for the purposes of a check

---

This PR has:

• been tested to ensure log ingestion and log query works.
• added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
• added documentation for new or modified features or behaviors.

Summary by CodeRabbit

• Refactor
  • Streamlined the JSON data conversion workflow to improve efficiency and ensure more consistent error reporting for invalid inputs.

[coderabbitai]

Walkthrough

The convert_to_array function in src/utils/json/flatten.rs was refactored. The updated implementation now uses the any method to check if any element in the input vector is not an object. If a non-object is found, the function returns an error; otherwise, it returns the original vector wrapped in a Value::Array. This streamlines the previous logic that employed an explicit loop and intermediate object creation.

Changes

File	Change Summary
src/utils/.../flatten.rs	Refactored convert_to_array to replace the explicit loop with an any method check. Now returns an error if any element is not an object; otherwise, returns a wrapped array.

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant convert_to_array
    Caller->>convert_to_array: Call convert_to_array(flattened)
    alt Contains non-object
        convert_to_array-->>Caller: Return error: "expected object not found"
    else All objects
        convert_to_array-->>Caller: Return Value::Array(flattened)
    end

Loading

Poem

In a burrow of bytes, I hop and cheer,
Seeing tidy logic now crystal clear.
Loops give way to swift any checks so neat,
Error or success—it's a rhythmic beat!
Code flows like a gentle springtime breeze,
A rabbit’s smile, as bugs take their leave.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 59a82d2 and 0cb248b.

📒 Files selected for processing (1)

• src/utils/json/flatten.rs (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (10)

• GitHub Check: Build Default x86_64-pc-windows-msvc
• GitHub Check: Build Default aarch64-apple-darwin
• GitHub Check: Build Default x86_64-apple-darwin
• GitHub Check: Build Kafka aarch64-apple-darwin
• GitHub Check: Build Default aarch64-unknown-linux-gnu
• GitHub Check: Build Kafka x86_64-unknown-linux-gnu
• GitHub Check: Quest Smoke and Load Tests for Distributed deployments
• GitHub Check: coverage
• GitHub Check: Build Default x86_64-unknown-linux-gnu
• GitHub Check: Quest Smoke and Load Tests for Standalone deployments

🔇 Additional comments (1)

src/utils/json/flatten.rs (1)

337-343: Great optimization!

The refactored implementation eliminates unnecessary cloning while maintaining the same functionality. Using any to check for non-objects is both more efficient and more concise.

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.