Skip to content

Commit 5137ed0

Browse files
committed
Modify component conversion document
1 parent af0d8a5 commit 5137ed0

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

component-conversion.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
<!------------->
1919
<!-- becomes -->
2020
<!------------->
21-
angular.module('patternfly.notification').directive('pfNotificationDrawer', {
21+
angular.module('patternfly.notification').component('pfNotificationDrawer', {
2222
bindings: {
2323
scrollSelector: '@',
2424
groupHeight: '@',
@@ -32,7 +32,7 @@
3232
```
3333
3. Any initialization logic should be moved out of link functions and into $onInit functions
3434
4. Any event listeners that are added for $window or $timeout events should be cleaned up in $onDestroy
35-
5. $scope watchers should be moved to $onChanges
35+
5. $scope watchers should be moved to $onChanges for bound properties (defined in bindings object)
3636
6. If DOM manipulation still must happen, there is a $postLink function. A bit more investigation will be necessary to see if these components can be upgraded to Angular 2.
3737

3838
## View Conversion

0 commit comments

Comments
 (0)