Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading state/error state for conversation history #326

Closed
rebeccaalpert opened this issue Nov 19, 2024 · 3 comments · Fixed by #445
Closed

Loading state/error state for conversation history #326

rebeccaalpert opened this issue Nov 19, 2024 · 3 comments · Fixed by #445
Assignees
Labels
PF6 Applies to only the PF6 version
Milestone

Comments

@rebeccaalpert
Copy link
Member

rebeccaalpert commented Nov 19, 2024

RHDH is looking for a loading state, empty state, and error state for conversation history.

Waiting on patternfly/patternfly-design-kit#774 and patternfly/patternfly-design-kit#775.

@rebeccaalpert rebeccaalpert added the PF6 Applies to only the PF6 version label Nov 19, 2024
@rebeccaalpert rebeccaalpert self-assigned this Nov 19, 2024
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Nov 19, 2024
@rebeccaalpert rebeccaalpert added this to the 2024.Q4 milestone Nov 19, 2024
@rebeccaalpert rebeccaalpert moved this from Needs triage to Blocked in PatternFly Issues Nov 20, 2024
@rebeccaalpert rebeccaalpert changed the title Loading state for conversation history Loading state/error state for conversation history Nov 20, 2024
@rebeccaalpert rebeccaalpert modified the milestones: 2024.Q4, 2025.Q1 Dec 6, 2024
@rebeccaalpert rebeccaalpert changed the title Loading state/error state for conversation history Loading state/error state/empty state for conversation history Jan 10, 2025
@kaylachumley
Copy link

This is ready to go! I updated the figma kit to reflect the design changes.


Error state is using a empty state with status component to represent failed content. The icon status color is using pf-t--global--icon--color--status--danger--default

Error State Dark Mode:

Image

Error State Light Mode:

Image


The loading state, per Andrews recommendation, should use a skeleton loader since we are exposing content incrementally and we know what the expected content layout will be every time. Since figma has some limitations with animations and we do not yet support gradient tokens, the figma designs use a flat fill for the skeleton. The actual skeleton loader should adopt the animated gradient that's on org.

Loading State Light Mode:

Image

Loading State Dark Mode:

Image

@rebeccaalpert rebeccaalpert changed the title Loading state/error state/empty state for conversation history Loading state/error state for conversation history Feb 12, 2025
@rebeccaalpert
Copy link
Member Author

rebeccaalpert commented Feb 12, 2025

See #442 for empty state; breaking out separately.

@rebeccaalpert rebeccaalpert moved this from Blocked to Not started in PatternFly Issues Feb 12, 2025
@kaylachumley
Copy link

kaylachumley commented Feb 13, 2025

Hey! @rebeccaalpert I received some content feedback from Erin

Here is the updated copy for the error state:

Image

@rebeccaalpert rebeccaalpert moved this from Not started to PR Review in PatternFly Issues Feb 17, 2025
@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PF6 Applies to only the PF6 version
Projects
Archived in project
2 participants