Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chatbot: Messages need an inline error state #773

Closed
kaylachumley opened this issue Nov 20, 2024 · 5 comments
Closed

Chatbot: Messages need an inline error state #773

kaylachumley opened this issue Nov 20, 2024 · 5 comments
Assignees
Labels
Figma Related to Figma library PatternFly 6
Milestone

Comments

@kaylachumley
Copy link
Collaborator

Per request from the RHDH LS team, we need to create a message level inline error state for failed instances.

example: when a user waits for the AI message streaming to complete but for some reason the streaming is stopped. In this case we may want to surface the error happened only on the last message from the bot/AI.

Image
Image

@kaylachumley kaylachumley added Figma Related to Figma library PatternFly 6 labels Nov 20, 2024
@kaylachumley kaylachumley added this to the 2024.Q4 milestone Nov 20, 2024
@kaylachumley kaylachumley self-assigned this Nov 20, 2024
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Nov 20, 2024
@andrew-ronaldson andrew-ronaldson modified the milestones: 2024.Q4, 2025.Q1 Dec 17, 2024
@kaylachumley kaylachumley moved this from Needs triage to Not started in PatternFly Issues Jan 14, 2025
@kaylachumley kaylachumley moved this from Not started to In Progress in PatternFly Issues Feb 11, 2025
@kaylachumley
Copy link
Collaborator Author

@andrew-ronaldson I opted to adopt the current pf text input error state for this. What are your thoughts? If none, this is ready to go for rebecca to implement.

Dark:

Image

Light:

Image

@kaylachumley kaylachumley moved this from In Progress to PR Review in PatternFly Issues Feb 11, 2025
@kaylachumley
Copy link
Collaborator Author

kaylachumley commented Feb 13, 2025

Updated design per team feedback:

Leans toward inline alert - no dismiss

  • Reading left to right makes sense - icon position adds context
  • No ability to dismiss
  • Nicole wants a general inline alert that people can customize. Minimize tweaks out of the box. Keep Inline with chat

Using the inline alert component with no dismissal to start

Image

@kaylachumley kaylachumley moved this from PR Review to Done in PatternFly Issues Feb 13, 2025
@andrew-ronaldson
Copy link
Contributor

Looks good to me. Is this going to be added as a "message type" variant in the Figma file?

@kaylachumley
Copy link
Collaborator Author

yes! @andrew-ronaldson I added it in the message group as a bot error variant

Image

@andrew-ronaldson
Copy link
Contributor

Cool beans. Closing as donezo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Figma Related to Figma library PatternFly 6
Projects
Archived in project
Development

No branches or pull requests

2 participants