Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split turn in two stages: Proposal and voting #106

Open
7 tasks
peersky opened this issue Jan 4, 2025 · 0 comments
Open
7 tasks

Split turn in two stages: Proposal and voting #106

peersky opened this issue Jan 4, 2025 · 0 comments
Labels
Beta Release Project roadmap item for beta release enhancement New feature or request help wanted Extra attention is needed

Comments

@peersky
Copy link
Member

peersky commented Jan 4, 2025

Current implementation of CVPP simplified in this repository and has shown negative feedback from users as it first requires everyone to submit next batch of proposals and only then will show feedback from previous round.

To fix this we must create flow where each turn consists of two distinct sections:

  • Voting
  • Proposing

This means that players no longer vote on "previous round proposals" but instead vote on current round.

The straightforward solution that is less work on a refactor side for us would be to

  • Add CVPP wrapper to LibTBG that converts odd turns to a proposal stages and even a vote stage
  • Add new game master facet method to submit proposals batch which can be done only to end odd turns in libtbg
  • Convert endTurn method to submit votes batch, which can be used only to end even turns (in libtbg)
  • Remove canEndTurn functionality from LibRankify and facets. Add canEndProposing, canEndVoting instead.
  • Return proposing stage in to game state returns to allow dApp distinguish stage of a turn
  • getTurn method should use CVPP wrapper instead of directly talking to LibTBG (divide libtbg by 2)
  • Update readme, documentation
@peersky peersky added enhancement New feature or request help wanted Extra attention is needed Beta Release Project roadmap item for beta release labels Jan 4, 2025
@peersky peersky added this to the Testnet deployment milestone Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Beta Release Project roadmap item for beta release enhancement New feature or request help wanted Extra attention is needed
Projects
Status: Ready
Development

No branches or pull requests

1 participant