Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge playbook utils and test utils #118

Open
peersky opened this issue Jan 11, 2025 · 0 comments
Open

Merge playbook utils and test utils #118

peersky opened this issue Jan 11, 2025 · 0 comments
Labels
debt Technical Debt good first issue Good for newcomers

Comments

@peersky
Copy link
Member

peersky commented Jan 11, 2025

There are two utils files that pretty much duplicate each other:

  • test/utils.ts
  • playbook/utils.ts

We would want to reduce duplication by using playbooks one within tests and removing test one.

There are slight API changes in playbooks as well as it may return different proposal text data.

@peersky peersky added good first issue Good for newcomers debt Technical Debt labels Jan 11, 2025
@peersky peersky moved this to Backlog in OpenSource Kanban Board Jan 11, 2025
@peersky peersky moved this from Backlog to Ready in OpenSource Kanban Board Jan 11, 2025
@peersky peersky added this to the Testnet deployment milestone Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt Technical Debt good first issue Good for newcomers
Projects
Status: Ready
Development

No branches or pull requests

1 participant