Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup tasks #241

Open
mivade opened this issue Aug 7, 2018 · 0 comments
Open

Cleanup tasks #241

mivade opened this issue Aug 7, 2018 · 0 comments
Labels

Comments

@mivade
Copy link
Contributor

mivade commented Aug 7, 2018

A lot of tasks needlessly define wrapper functions which just call another function. This makes the code hard to follow. Instead, we should be using the task decorator directly. Example:

@task()
def generate_pairs_for_classifier(pairs, excluded_pairs):
return generate_pairs_for_classifier_core(pairs, excluded_pairs)

@mivade mivade added the cleanup label Aug 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant