Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

looper report messaging #533

Open
nsheff opened this issue Oct 17, 2024 · 0 comments
Open

looper report messaging #533

nsheff opened this issue Oct 17, 2024 · 0 comments
Assignees

Comments

@nsheff
Copy link
Contributor

nsheff commented Oct 17, 2024

looper report happily created an empty report for me:

looper report --portable
Looper version: 2.0.0a2
Command: report
Using looper config (.looper.yaml).
No config key in Project, or reading project from dict
Portable flag set: True
Building index page for pipeline: PEPATAC
Creating objects summary
'PEPATAC' pipeline stats summary (n=1): /project/shefflab/brickyard/results_pipeline/.../PEPATAC_stats_summary.tsv
'PEPATAC' pipeline objects summary (n=0): /project/shefflab/brickyard/results_pipeline/.../PEPATAC_objs_summary.yaml
 * Creating sample pages
 * Creating object pages
Report zip file successfully created: /project/shefflab/brickyard/results_pipeline/.../portable_reports/PEPATAC_report_portable
Report directory: /project/shefflab/brickyard/results_pipeline/.../portable_reports/PEPATAC/index.html
Portable flag set: True
Building index page for pipeline: PEPATAC
Creating objects summary
'PEPATAC' pipeline stats summary (n=1): /project/shefflab/brickyard/results_pipeline/.../PEPATAC_stats_summary.tsv
'PEPATAC' pipeline objects summary (n=0): /project/shefflab/brickyard/results_pipeline/.../PEPATAC_objs_summary.yaml
 * Creating sample pages
 * Creating object pages
Report zip file successfully created: /project/shefflab/brickyard/results_pipeline/.../portable_reports/PEPATAC_report_portable

...

I guess it couldn't find the samples or the stats or something. So, there needs to be some better checking to avoid just happily creating an empty report.

What should happen

instead of creating a report, I would expect it to say something like "no results found" with some helpful information about how my project may be misconfigured. It never really makes sense to produce an empty report with no records, I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants