-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Running against a new server without a typemap/stream spec will cause errors on trying to set up either. #1
Comments
perforce#1 Added test for when typemap is empty update get_typemap to return empty list if no typemap, rather than throwing exception.
Thanks Brett! Let me know if there's something I've missed and that fetch_stream can return an empty dict. Otherwise hopefully this gets merged and we can close the issue! |
Thanks Jase, For fetch streams, I conflated a very similar issue with iterate_streams(), which usually just runs 'p4 streams' and creates an iterator. In the case that 'p4 streams' is empty, you get an exception for the warning 'No such stream.'. Needs a try/except P4.P4Exception
|
The 'p4 streams' and 'p4 typemap' specs don't get populated correctly by the fetch_* commands if they are empty.
Apologies for not just giving you PR, I don't have permission from employer; but you can use .get("TypeMap", []) etc instead of ["TypeMap"] and all is fine. Thanks for the tool, it looks very promising.
The text was updated successfully, but these errors were encountered: