Link check tests

[ranguard]

Create something to check all links in the documents

[symkat]

I can take this, and will have something before the weekend if no one has started on anything yet?

[rafl]

JFDI! :-)

[acme]

Please steal from the script in the core:

http://perl5.git.perl.org/perl.git/blob/HEAD:/Porting/checkURL.pl

(That had to ignore the perlfaq as it had too many broken URLs)

[doherty]

Are Dist::Zilla::Plugin::Test::Pod::LinkCheck and Dist::Zilla::Plugin::Test::Pod::No404s not sufficient?

[ranguard]

They would be a great start if nothing else, not sure how they deal with perldoc link checks - pull requests welcome

[doherty]

It resolves perldoc links just fine, and it will even check that the section exists if you link to a specific section.

Currently, the test is throwing a bunch of possibly-spurious failures. I'm investigating...

$ RELEASE_TESTING=yes prove t/release-pod-linkcheck.t
t/release-pod-linkcheck.t .. 8/12 
#   Failed test 'LinkCheck test for lib/perlfaq2.pod'
#   at /home/mike/perl5/perlbrew/perls/perl-5.14.2/lib/site_perl/5.14.2/Test/Pod/LinkCheck.pm line 213.
# Erroneous links: 
#  * lib/perlfaq2.pod:154:5 - Unknown link type(pod) to() section(What modules and extensions are available for Perl? What is CPAN? What does CPAN/src/... mean?) - section doesn't exist!
#  * lib/perlfaq2.pod:158:21 - Unknown link type(pod) to(lists.perl.org) - module doesn't exist in CPAN
t/release-pod-linkcheck.t .. 10/12 
#   Failed test 'LinkCheck test for lib/perlfaq9.pod'
#   at /home/mike/perl5/perlbrew/perls/perl-5.14.2/lib/site_perl/5.14.2/Test/Pod/LinkCheck.pm line 213.
# Erroneous links: 
#  * lib/perlfaq9.pod:500:41 - Unknown link type(man) to(mail(1))
#  * lib/perlfaq9.pod:500:52 - Unknown link type(man) to(mailx(1))
t/release-pod-linkcheck.t .. 11/12 
#   Failed test 'LinkCheck test for lib/perlfaq5.pod'
#   at /home/mike/perl5/perlbrew/perls/perl-5.14.2/lib/site_perl/5.14.2/Test/Pod/LinkCheck.pm line 213.
# Erroneous links: 
#  * lib/perlfaq5.pod:1101:28 - Unknown link type(pod) to(Tie::FileHandle::Multiplex) - module doesn't exist in CPAN
t/release-pod-linkcheck.t .. 12/12 
#   Failed test 'LinkCheck test for lib/perlfaq8.pod'
#   at /home/mike/perl5/perlbrew/perls/perl-5.14.2/lib/site_perl/5.14.2/Test/Pod/LinkCheck.pm line 213.
# Erroneous links: 
#  * lib/perlfaq8.pod:491:32 - Unknown link type(pod) to(pwd_mkdb(8)) - module doesn't exist in CPAN
# Looks like you failed 4 tests of 12.
t/release-pod-linkcheck.t .. Dubious, test returned 4 (wstat 1024, 0x400)
Failed 4/12 subtests 

Test Summary Report
-------------------
t/release-pod-linkcheck.t (Wstat: 1024 Tests: 12 Failed: 4)
  Failed tests:  8, 10-12
  Non-zero exit status: 4
Files=1, Tests=12, 69 wallclock secs ( 0.04 usr  0.00 sys + 60.26 cusr 11.92 csys = 72.22 CPU)
Result: FAIL

[doherty]

Some of the failures were indeed spurious. I'll follow the bug reports I filed and try this again when they're fixed.

[ranguard]

great - thanks for all your input