You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
(This issue tracker is only for bug reports or feature requests, if this is neither, please choose appropriate channel from http://bluebirdjs.com/docs/support.html)
Please answer the questions the best you can:
What version of bluebird is the issue happening on? master branch @3.7.2
What platform and version? (For example Node.js 0.12 or Google Chrome 32) macOS nodejs 10.22.1
Did this issue happen with earlier version of bluebird? None
I think the comparison in the benchmark is not fair as promises-bluebird.js uses concurrency, but promises-native-async-await.js uses not concurrency. Here is a code example:
// file promises-bluebird.js varblobIdP=blob.put(stream);varfileP=self.byUuidOrPath(idOrPath).get();varversion,fileId,file;bluebird.join(blobIdP,fileP,function(blobId,fileV){// <----this is concurrent
...
})
vs
varblob=blobManager.create(account);vartx=db.begin();varblobId=awaitblob.put(stream);// <----this is not concurrentvarfile=awaitself.byUuidOrPath(idOrPath).get();// <----this is not concurrent
At least should be the following to be fair:
varblob=blobManager.create(account);vartx=db.begin();varblobId=blob.put(stream);varfile=self.byUuidOrPath(idOrPath).get();[blobId,file]=awaitPromise.all([blobId,file]);// <----this is concurrent
The text was updated successfully, but these errors were encountered:
(This issue tracker is only for bug reports or feature requests, if this is neither, please choose appropriate channel from http://bluebirdjs.com/docs/support.html)
Please answer the questions the best you can:
What version of bluebird is the issue happening on? master branch @3.7.2
What platform and version? (For example Node.js 0.12 or Google Chrome 32) macOS nodejs 10.22.1
Did this issue happen with earlier version of bluebird? None
I think the comparison in the benchmark is not fair as promises-bluebird.js uses concurrency, but promises-native-async-await.js uses not concurrency. Here is a code example:
vs
At least should be the following to be fair:
The text was updated successfully, but these errors were encountered: