Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to run the switch-to-react branch? #93

Closed
Enough7 opened this issue Jan 13, 2025 · 4 comments
Closed

How to run the switch-to-react branch? #93

Enough7 opened this issue Jan 13, 2025 · 4 comments

Comments

@Enough7
Copy link
Contributor

Enough7 commented Jan 13, 2025

Hi @phoinixi,

How do I run the switch-to-react branch?
I want to introduce a german localisation using i18next.
I much more comfortable with react than with handlebars, so I would like to switch to said branch, but I can not figure out how to build my cv.

Best regards
Enough7

@phoinixi
Copy link
Owner

Unfortunately that branch it's not ready, I will need to find some time to finish it. @levino made a nice fork which solves your problem though at https://github.com/levino/jsonresume-theme-stackoverflow-react.

I could not merge it because I see it too specific for what I have in mind, I'd like to keep the template easy.

@Enough7
Copy link
Contributor Author

Enough7 commented Jan 15, 2025

Hi,

yeah I noticed said forked, but as far as I know it only supports two languages and is already archived for a year.

I solved the problem already on my fork (#94) but I use it in a quite hacky way.
I generate the HTML on a NodeJS Backend and import as an iFrame in my React-App, next to my motivational letter.
It would be much easy to fetch the resume.json and then inject it in your future React App.

Let me know when its ready and if you need any help.

Best regards,
Paul

@Enough7 Enough7 closed this as completed Jan 15, 2025
@levino
Copy link
Contributor

levino commented Jan 15, 2025

I admit, that it is a bit confusing. You are currently in the repository for jsonresume-theme-stackoverflow. I created jsonresume-theme-stackoverflow-react. In NPM I added the deprecation notice that it has been republished under @jsonrume/theme-stackoverflow. You can find the source code in the monorepo of jsonresume.

I am a bit unhappy with the fact that the two projects did not merge and now we have this naming confusion. I also talked about my reasons here in the repo. I would appreciate if we all took a moment to come up with a clever solution.

@Enough7 if you still have troubles getting the code to run locally, please open an issue in the jsonresume repository and I will take a look.

@Enough7
Copy link
Contributor Author

Enough7 commented Jan 15, 2025

@levino Thanks for the clarification. I will come back to it later. I am currently working on my motivation letter feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants