Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-final method marked as @phpstan-impure says it is always pure when it could be overridden #12382

Open
dktapps opened this issue Jan 6, 2025 · 1 comment · May be fixed by phpstan/phpstan-src#3913
Open

Non-final method marked as @phpstan-impure says it is always pure when it could be overridden #12382

dktapps opened this issue Jan 6, 2025 · 1 comment · May be fixed by phpstan/phpstan-src#3913
Labels
bug
Milestone
Easy fixes

Comments

@dktapps
Copy link
Contributor

dktapps commented Jan 6, 2025

Bug report

In the given test case, the dummy() method is explicitly marked as impure, because subclasses may override it to do impure things (this is what I expect them to do).

However, PHPStan 2.x now complains about this annotation because the base class method doesn't do anything impure.

Code snippet that reproduces the problem

https://phpstan.org/r/8f21a11b-7517-4d98-a277-f4f210d063c7

Expected output

No error should be reported. The function & class are non-final.

Did PHPStan help you today? Did it make you happy in any way?

No response
@ondrejmirtes
Copy link
Member

Sure, in this case we should only report it for final methods/final classes.

@ondrejmirtes ondrejmirtes added this to the Easy fixes milestone Jan 7, 2025
@VincentLanglet VincentLanglet linked a pull request Mar 31, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
Easy fixes
Development

Successfully merging a pull request may close this issue.

Disable purity check for non final methods VincentLanglet/phpstan-src
2 participants
@ondrejmirtes @dktapps