Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Make ngx_stream module an optional feature #57

Closed
dedok opened this issue Feb 2, 2025 · 4 comments
Closed

[Proposal] Make ngx_stream module an optional feature #57

dedok opened this issue Feb 2, 2025 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@dedok
Copy link
Collaborator

dedok commented Feb 2, 2025

Description

We don't use ngx_stream module in the production and we do not have it in the compilation. As I know not all user's of nginx using --with-stream module. If try to compile this module w/o --with-stream, error appears.

Proposal

Enable compilation of ngx_stream_ssl_fingerprint_preread_module.c iff nginx's internal flag which set by Nginx's configure is present, else do not build ngx_stream_ssl_fingerprint_preread_module.c at all.

@phuslu
Copy link
Owner

phuslu commented Feb 2, 2025

Yes, that's right, providing an optional ngx_stream will make this module more comprehensive.

@dedok dedok self-assigned this Feb 2, 2025
@dedok dedok added the enhancement New feature or request label Feb 3, 2025
@dedok
Copy link
Collaborator Author

dedok commented Feb 3, 2025

This is done in: https://github.com/phuslu/nginx-ssl-fingerprint/tree/fix-ssl-extentions-for-openssl-3-4
But need a ~1 day to done with testing.

@dedok
Copy link
Collaborator Author

dedok commented Feb 6, 2025

PR: #62

@dedok
Copy link
Collaborator Author

dedok commented Feb 6, 2025

Close this one, since it will be available after merge.

@dedok dedok closed this as completed Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants