Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dep(*): move code of sync_diff_inspector from tidb-tools to tiflow #11671

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

dep(*): move code of sync_diff_inspector from tidb-tools to tiflow #11671

wants to merge 18 commits into from
+12,699 −0

Conversation

joechenrh
Copy link

@joechenrh joechenrh commented Oct 21, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #11672

What is changed and how it works?

Since the only module in use in tidb-tools is sync_diff_inspector, which is used by DM and CDC. So we want to move this package into tiflow repo, and then we can deprecate tidb-tools repo.

Note:

  • This PR only moves the code of sync_diff_inspector into tiflow, but the scripts for downloading sync_diff_inspector remain unchanged. Since It seems like CI rely on these scripts.
  • sync_diff_inspector will not be built using Makefile.

Check List

Tests

  • Unit test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Oct 21, 2024
@sre-bot
Copy link

sre-bot commented Oct 21, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/dm Issues or PRs related to DM. labels Oct 21, 2024
@joechenrh joechenrh changed the title *: move sync_diff_inspector from tidb-tools to tiflow dep(*): move sync_diff_inspector from tidb-tools to tiflow Oct 21, 2024
@joechenrh
Copy link
Author

/retest

@joechenrh
Copy link
Author

/test verify

@codecov Codecov
Copy link

codecov bot commented Oct 22, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 55.86279% with 2123 lines in your changes missing coverage. Please review.

Project coverage is 55.1810%. Comparing base (62d07b5) to head (ec82382).
Report is 13 commits behind head on master.

Additional details and impacted files
Components Coverage Δ
cdc 59.6195% <ø> (-0.2093%) ⬇️
dm 50.0616% <ø> (+0.0076%) ⬆️
engine 53.2674% <ø> (+0.0338%) ⬆️
Flag Coverage Δ
unit 55.1810% <55.8627%> (-0.0632%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #11671        +/-   ##
================================================
- Coverage   55.2441%   55.1810%   -0.0632%     
================================================
  Files          1001       1025        +24     
  Lines        136237     141284      +5047     
================================================
+ Hits          75263      77962      +2699     
- Misses        55486      57621      +2135     
- Partials       5488       5701       +213

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Oct 22, 2024
@joechenrh
Copy link
Author

/retest

1 similar comment
@joechenrh
Copy link
Author

/retest

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 23, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 23, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-23 08:45:06.448555492 +0000 UTC m=+427107.145346094: ☑️ agreed by lance6716.

@ti-chi-bot ti-chi-bot bot added the approved label Oct 23, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@joechenrh joechenrh changed the title dep(*): move sync_diff_inspector from tidb-tools to tiflow dep(*): move code of sync_diff_inspector from tidb-tools to tiflow Oct 25, 2024
wuhuizuo
wuhuizuo reviewed Oct 25, 2024
View reviewed changes
go.mod Outdated
@@ -345,7 +346,7 @@ require (
github.com/shurcooL/httpfs v0.0.0-20230704072500-f1e31cf0ba5c // indirect
github.com/shurcooL/httpgzip v0.0.0-20190720172056-320755c1c1b0 // indirect
github.com/shurcooL/vfsgen v0.0.0-20200824052919-0d455de96546 // indirect
github.com/siddontang/go v0.0.0-20180604090527-bdc77568d726 // indirect
github.com/siddontang/go v0.0.0-20180604090527-bdc77568d726
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please move it to direct group to keep it pretty.

Copy link
Author

@joechenrh joechenrh Oct 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8e601b3

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 25, 2024

@joechenrh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-engine-integration-test ec82382 link true /test engine-integration-test
pull-cdc-integration-kafka-test ec82382 link true /test cdc-integration-kafka-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wuhuizuo
Copy link
Contributor

/hold

merge it when v8.5.0 released.

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wuhuizuo wuhuizuo wuhuizuo left review comments

@lance6716 lance6716 lance6716 approved these changes

Assignees
No one assigned
Labels
approved area/dm Issues or PRs related to DM. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. needs-1-more-lgtm Indicates a PR needs 1 more LGTM. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

move diff package from tidb-tools to tiflow repo
4 participants
@joechenrh @sre-bot @wuhuizuo @lance6716