Skip to content

Commit e934f28

Browse files
committed
comment out ts-consumer for testing
1 parent ced0922 commit e934f28

File tree

3 files changed

+39
-40
lines changed

3 files changed

+39
-40
lines changed

psc-integration-test/pom.xml

+19-19
Original file line numberDiff line numberDiff line change
@@ -53,25 +53,25 @@
5353
</exclusion>
5454
</exclusions>
5555
</dependency>
56-
<dependency>
57-
<groupId>com.pinterest.kafka.tieredstorage</groupId>
58-
<artifactId>ts-consumer</artifactId>
59-
<version>${ts-consumer.version}</version>
60-
<exclusions>
61-
<exclusion>
62-
<groupId>log4j</groupId>
63-
<artifactId>log4j</artifactId>
64-
</exclusion>
65-
<exclusion>
66-
<groupId>org.slf4j</groupId>
67-
<artifactId>slf4j-log4j12</artifactId>
68-
</exclusion>
69-
<exclusion>
70-
<groupId>org.slf4j</groupId>
71-
<artifactId>log4j-over-slf4j</artifactId>
72-
</exclusion>
73-
</exclusions>
74-
</dependency>
56+
<!-- <dependency>-->
57+
<!-- <groupId>com.pinterest.kafka.tieredstorage</groupId>-->
58+
<!-- <artifactId>ts-consumer</artifactId>-->
59+
<!-- <version>${ts-consumer.version}</version>-->
60+
<!-- <exclusions>-->
61+
<!-- <exclusion>-->
62+
<!-- <groupId>log4j</groupId>-->
63+
<!-- <artifactId>log4j</artifactId>-->
64+
<!-- </exclusion>-->
65+
<!-- <exclusion>-->
66+
<!-- <groupId>org.slf4j</groupId>-->
67+
<!-- <artifactId>slf4j-log4j12</artifactId>-->
68+
<!-- </exclusion>-->
69+
<!-- <exclusion>-->
70+
<!-- <groupId>org.slf4j</groupId>-->
71+
<!-- <artifactId>log4j-over-slf4j</artifactId>-->
72+
<!-- </exclusion>-->
73+
<!-- </exclusions>-->
74+
<!-- </dependency>-->
7575
<dependency>
7676
<groupId>com.pinterest.psc</groupId>
7777
<artifactId>psc-logging</artifactId>

psc/pom.xml

+19-19
Original file line numberDiff line numberDiff line change
@@ -35,25 +35,25 @@
3535
</exclusion>
3636
</exclusions>
3737
</dependency>
38-
<dependency>
39-
<groupId>com.pinterest.kafka.tieredstorage</groupId>
40-
<artifactId>ts-consumer</artifactId>
41-
<version>${ts-consumer.version}</version>
42-
<exclusions>
43-
<exclusion>
44-
<groupId>log4j</groupId>
45-
<artifactId>log4j</artifactId>
46-
</exclusion>
47-
<exclusion>
48-
<groupId>org.slf4j</groupId>
49-
<artifactId>slf4j-log4j12</artifactId>
50-
</exclusion>
51-
<exclusion>
52-
<groupId>org.slf4j</groupId>
53-
<artifactId>log4j-over-slf4j</artifactId>
54-
</exclusion>
55-
</exclusions>
56-
</dependency>
38+
<!-- <dependency>-->
39+
<!-- <groupId>com.pinterest.kafka.tieredstorage</groupId>-->
40+
<!-- <artifactId>ts-consumer</artifactId>-->
41+
<!-- <version>${ts-consumer.version}</version>-->
42+
<!-- <exclusions>-->
43+
<!-- <exclusion>-->
44+
<!-- <groupId>log4j</groupId>-->
45+
<!-- <artifactId>log4j</artifactId>-->
46+
<!-- </exclusion>-->
47+
<!-- <exclusion>-->
48+
<!-- <groupId>org.slf4j</groupId>-->
49+
<!-- <artifactId>slf4j-log4j12</artifactId>-->
50+
<!-- </exclusion>-->
51+
<!-- <exclusion>-->
52+
<!-- <groupId>org.slf4j</groupId>-->
53+
<!-- <artifactId>log4j-over-slf4j</artifactId>-->
54+
<!-- </exclusion>-->
55+
<!-- </exclusions>-->
56+
<!-- </dependency>-->
5757
<dependency>
5858
<groupId>org.reflections</groupId>
5959
<artifactId>reflections</artifactId>

psc/src/main/java/com/pinterest/psc/consumer/kafka/PscKafkaConsumer.java

+1-2
Original file line numberDiff line numberDiff line change
@@ -107,8 +107,7 @@ public void initializeBackend(ServiceDiscoveryConfig discoveryConfig, TopicUri t
107107

108108
@Override
109109
protected synchronized void reportConsumerMetrics() {
110-
// temporary fix to avoid NPE in KafkaConsumer.metrics()
111-
if (kafkaConsumer == null || kafkaConsumer.metrics() == null)
110+
if (kafkaConsumer == null)
112111
return;
113112

114113
Map<org.apache.kafka.common.MetricName, ? extends org.apache.kafka.common.Metric> kafkaMetrics = kafkaConsumer.metrics();

0 commit comments

Comments
 (0)