Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Parsing Extensions in Candidates #753

Closed
JoeTurki opened this issue Jan 14, 2025 · 0 comments · Fixed by #754
Closed

Add Support for Parsing Extensions in Candidates #753

JoeTurki opened this issue Jan 14, 2025 · 0 comments · Fixed by #754
Assignees
Labels
enhancement New feature or request

Comments

@JoeTurki
Copy link
Member

The UnmarshalCandidate function should be improved to align more y with the ICE Candidate parsing rules outlined in RFC 5245, Section 15.1.

In addition, candidateBase should support access to extension values. This includes:

Parsing and storing extensions in a structured way.
Matching specific extensions for validation or other purposes.
Serializing (marshaling) the candidate, including its extensions, back into a string.

This is required for many issues like pion/webrtc#2993

I'm making a PR.

@JoeTurki JoeTurki self-assigned this Jan 14, 2025
@JoeTurki JoeTurki added the enhancement New feature or request label Jan 14, 2025
@JoeTurki JoeTurki changed the title Add Support for Parsing Extensions in SDP Add Support for Parsing Extensions in Candidates Jan 14, 2025
@JoeTurki JoeTurki linked a pull request Jan 15, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging a pull request may close this issue.

1 participant