Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix relative links to configuration-reference of Notification #5608

Merged
merged 2 commits into from
Feb 26, 2025

Conversation

t-kikuc
Copy link
Member

@t-kikuc t-kikuc commented Feb 26, 2025

What this PR does:

as title
Three links were wrong.

Why we need it:

Notifications are described in managing-piped/configuration-reference.md, not user-guide/configuration-reference.md

Which issue(s) this PR fixes:

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

@t-kikuc t-kikuc enabled auto-merge (squash) February 26, 2025 10:50
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.53%. Comparing base (42df575) to head (fd035db).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5608      +/-   ##
==========================================
+ Coverage   26.26%   26.53%   +0.27%     
==========================================
  Files         474      474              
  Lines       50496    50505       +9     
==========================================
+ Hits        13263    13403     +140     
+ Misses      36171    36039     -132     
- Partials     1062     1063       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@t-kikuc t-kikuc changed the title docs: Fix relative links to configuration-reference docs: Fix relative links to configuration-reference of Notification Feb 26, 2025
Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@t-kikuc t-kikuc merged commit e49c4fc into master Feb 26, 2025
18 checks passed
@t-kikuc t-kikuc deleted the docs/fix-link-notif branch February 26, 2025 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants