Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deployment trace ui #5610

Merged
merged 1 commit into from
Feb 27, 2025
Merged

Update deployment trace ui #5610

merged 1 commit into from
Feb 27, 2025

Conversation

hongky-1994
Copy link
Contributor

What this PR does:

  • Change title from 'Deployment traces' to 'Traces'
  • Add hover effect for trace-item in list
  • Fix bugs overflow header on mobile view.
  • Not hide btn commit message when open deployment list

Why we need it:

  • For better UI and UX
    CleanShot 2025-02-27 at 17 23 17@2x
    CleanShot 2025-02-27 at 17 24 29
    CleanShot 2025-02-27 at 17 25 28@2x

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

- Change title from 'Deployment traces' to 'Traces'
- Add hover effect for trace-item in list
- Fix bugs overflow header on mobile view.
- Not hide btn commit message when open deployment list

Signed-off-by: kypham <[email protected]>
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.56%. Comparing base (9d89463) to head (dea4b55).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5610   +/-   ##
=======================================
  Coverage   26.56%   26.56%           
=======================================
  Files         474      474           
  Lines       50535    50535           
=======================================
+ Hits        13423    13427    +4     
+ Misses      36048    36045    -3     
+ Partials     1064     1063    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khanhtc1202
Copy link
Member

Hi @hongky-1994, Thanks for the speed :D
I just want to confirm one point. With the hover effect added to the Trace item, will the user be able to see the deployment list by clicking on the item or having to click on the right-size arrow?

@hongky-1994
Copy link
Contributor Author

Hi @hongky-1994, Thanks for the speed :D I just want to confirm one point. With the hover effect added to the Trace item, will the user be able to see the deployment list by clicking on the item or having to click on the right-size arrow?

Currently user have to click btn arrow on the right side. We can implement click on item feature but, in the deployment trace item , we have commit link which is hover show cursor pointer too, this may make user doesn't know where to click.

@khanhtc1202
Copy link
Member

@hongky-1994 Got your point. Let's keep the current spec 👍

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@t-kikuc t-kikuc merged commit abd6218 into master Feb 27, 2025
18 checks passed
@t-kikuc t-kikuc deleted the feat/deployment-tracing-ui_2 branch February 27, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants