-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deployment trace ui #5610
Conversation
- Change title from 'Deployment traces' to 'Traces' - Add hover effect for trace-item in list - Fix bugs overflow header on mobile view. - Not hide btn commit message when open deployment list Signed-off-by: kypham <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5610 +/- ##
=======================================
Coverage 26.56% 26.56%
=======================================
Files 474 474
Lines 50535 50535
=======================================
+ Hits 13423 13427 +4
+ Misses 36048 36045 -3
+ Partials 1064 1063 -1 ☔ View full report in Codecov by Sentry. |
Hi @hongky-1994, Thanks for the speed :D |
Currently user have to click btn arrow on the right side. We can implement click on item feature but, in the deployment trace item , we have commit link which is hover show cursor pointer too, this may make user doesn't know where to click. |
@hongky-1994 Got your point. Let's keep the current spec 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
What this PR does:
Why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: