[Bug] Pinned tabs display poorly

[ned-martin]

Abstract

Edit: Behaviour described below is expected behaviour of a pinned tab.

The bug is that pinned tabs display poorly, and seem to cause unusual issues when control + tabbing, selecting them, etc.

Difficult to explain... when I open Firefox (which is set to not reopen any previous tabs, and only open a blank tab), TST shows as its first tab a sort of ghost tab. It is the same tab all the time. If I close Firefox and open it again, the same tab is shown as this ghost tab. Similarly, if I go to the ghost tab and change its URL, then it is permanently the new URL.

Steps to reproduce

1. Pin a tab (right click on tab, "pin tab"). Open Firefox. A ghost tab is shown, and a new blank tab (See screenshot below)
2. As per below screenshot, the pinned tab looks broken. I also experienced weird issues while control + tabbing and navigating around with it.

3. Open many new tabs, do normal browsing, etc. Everything works normally except the ghost tab stays there. Control + W etc. won't close it. Right click on menu and close does close it, but only if it's the last tab (and the whole browser then closes)
4. Close browser.
5. Restart browser.
6. Browser opens as per step 1, with the ghost tab and the new blank tab.
7. Close browser in a way that re-opens existing tabs (i.e. from a Firefox update, or via about:profiles "Restart normally"
8. Browser reopens with all existing tabs opened again as expected, but the ghost tab stays there.
9. Select the ghost tab and change its URL in the address bar to a different site. The ghost tab now stays as that site until manually changed again. Even after restarting Firefox multiple times, the ghost tab will always open and will always be the site that it was last set to.

Environment

• Platform (OS): Windows 11 23H2 22631.4602
• Version of Firefox: 135.0b2
• Version (or revision) of Tree Style Tab: tried with 5.0.25 from AMO, and also 4.1.1 from here.
• I have not yet tried in a blank, clean environment without any other plugins. It's annoying to do so I am hoping this is enough of a bug report without me needing to try that :)

[ned-martin]

Ok so I investigated further and noticed the tab was in a container with id="pinned-tabs-container" so a quick Google teaches me what a pinned tab is, and how to unpin it.

So I guess the issue of the ghost tab is solved, and this bug becomes an issue that TST doesn't seem to display the pinned tab properly.

[piroor]

Could you inspect what is the source of the unexpected gap, with the developer tools? https://github.com/piroor/treestyletab/wiki/How-to-inspect-tree-of-tabs#how-to-inspect-the-sidebar

[piroor]

On my environment, I've seen similar unexpected margin when the element "div#pinned-tabs-container" has a class "overflow". This is a screenshot I've manually added the class:

But currently it is not clear what triggers adding the unexpected "overflow" class.

[piroor]

I've added some codes to output more information which may help our debugging. Could you try the latest development build and collect logs only with the module "sidebar/pinned-tabs"?

Here is my logs:

The last line should be true on your case, with the problem. I hope to know values of height, maxRow, yOffset, mMaxVisibleRows and mAreaHeight on your case.

[github-actions]

This issue has been labeled as "stale" due to no response by the reporter within 1 month (and 7 days after last commented by someone). And it will be closed automatically 14 days later if not responded.

[ned-martin]

This issue has been labeled as "stale" due to no response by the reporter within 1 month (and 7 days after last commented by someone). And it will be closed automatically 14 days later if not responded.

Sorry have been away, will try look into this next week.