Merge pull request #19 from pixijs/feat/eslint-v9

feat!: upgrade to eslint v9

Author: Zyie

.github/workflows/build.yml

@@ -13,10 +13,10 @@ jobs:
     steps:
     - name: Checkout
       uses: actions/checkout@v3
-    - name: Use Node.js 16.x
-      uses: actions/setup-node@v3
+    - name: Use Node.js 20.x
+      uses: actions/setup-node@v4
       with:
-        node-version: 16
+        node-version: 20
     - name: Install npm
       run: npm install -g npm@8
     - name: Install Dependencies

eslint.config.mjs

@@ -0,0 +1,3 @@
+import config from './lib/configs/eslint.config.mjs';
+
+export default config;

lib/configs/eslint.config.mjs

@@ -0,0 +1,3 @@
+import config from '@pixi/eslint-config';
+
+export default config;

lib/configs/eslint.json

@@ -122,34 +122,29 @@ const fixGlobalTypes = async () =>
 /** Run ESlint with built-in config */
 const lint = async (additionalArgs = []) =>
 {
-    const eslintrcJson = path.join(process.cwd(), '.eslintrc.json');
-    const eslintrcJs = path.join(process.cwd(), '.eslintrc.js');
-    const eslintrc = path.join(process.cwd(), '.eslintrc');
+    const eslintMJS = path.join(process.cwd(), 'eslint.config.mjs');
+    const eslintJS = path.join(process.cwd(), 'eslint.config.js');
     const isDefined = 'eslintConfig' in packageInfo
-        || await pathExists(eslintrcJson)
-        || await pathExists(eslintrcJs)
-        || await pathExists(eslintrc);
+        || await pathExists(eslintMJS)
+        || await pathExists(eslintJS);
 
     if (!isDefined)
     {
         // We copy this file to the project if one doesn't exist
         // because using ESLint's -c parameter turns off eslintrc
         // which means that, tests, etc. won't be linted with a local .eslintrc
-        await promises.copyFile(path.join(__dirname, 'configs/eslint.json'), eslintrcJson);
+        await promises.copyFile(path.join(__dirname, 'configs/eslint.config.mjs'), eslintMJS);
     }
 
     const cleanup = async () =>
     {
         if (!isDefined)
         {
-            await promises.unlink(eslintrcJson);
+            await promises.unlink(eslintMJS);
         }
     };
 
     await spawn('eslint', [
-        '--ext', '.ts',
-        '--ext', '.js',
-        '--ext', '.mjs',
         '--no-error-on-unmatched-pattern',
         ...extensionConfig.lint,
         ...additionalArgs,
@@ -320,7 +315,6 @@ const runCommand = async (command, additionalArgs) =>
         }
         case Command.Watch: bundle('-w'); break;
         default: {
-            // eslint-disable-next-line no-console
             console.error(chalk.red(`${prefix} Error: Unknown command "${command}". `
             + `Only the following comands are supported: "${Object.values(Command).join('", "')}"\n`));
             process.exit(1);

lib/index.mjs

@@ -9,7 +9,8 @@ export const pathExists = async (path) =>
 
         return true;
     }
-    catch (e)
+    // eslint-disable-next-line @typescript-eslint/no-unused-vars
+    catch (_e)
     {
         return false;
     }

lib/utils/pathExists.mjs

@@ -9,12 +9,12 @@
   },
   "exports": {
     "./tsconfig": "./lib/configs/tsconfig.json",
-    "./eslint": "./lib/configs/eslint.json",
+    "./eslint": "./lib/configs/eslint.config.mjs",
     "./jest": "./lib/configs/jest.json"
   },
   "scripts": {
     "test": "npm run lint && cd test && npm i && npm test",
-    "lint": "eslint --ext .mjs -c lib/configs/eslint.json lib --max-warnings 0",
+    "lint": "eslint -c lib/configs/eslint.config.mjs lib --max-warnings 0",
     "lint:fix": "npm run lint -- --fix",
     "preversion": "npm test",
     "postversion": "npm publish && git push && git push --tags"
@@ -38,7 +38,7 @@
   "homepage": "https://github.com/pixijs/extension-scripts#readme",
   "dependencies": {
     "@kayahr/jest-electron-runner": "^29.3.0",
-    "@pixi/eslint-config": "^5.1.0",
+    "@pixi/eslint-config": "^6.0.0",
     "@pixi/rollup-plugin-rename-node-modules": "^2.0.0",
     "@pixi/webdoc-template": "^1.5.5",
     "@rollup/plugin-commonjs": "^24.0.0",
@@ -49,7 +49,7 @@
     "@webdoc/cli": "^2.2.0",
     "chalk": "^5.0.0",
     "clean-package": "^2.2.0",
-    "eslint": "^8.30.0",
+    "eslint": "^9.16.0",
     "gh-pages": "^4.0.0",
     "glob": "^10.3.10",
     "http-server": "^14.1.1",

package-lock.json

@@ -0,0 +1,5 @@
+{
+    "compilerOptions": {
+        "skipLibCheck": true
+    }
+}