Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💡 [Feature]: hide toolkit features that require being signed in to tenant until successful authentication #263

Closed
Adam-it opened this issue Jun 30, 2024 · 0 comments · Fixed by #307
Closed

💡 [Feature]: hide toolkit features that require being signed in to tenant until successful authentication #263

Adam-it opened this issue Jun 30, 2024 · 0 comments · Fixed by #307
Assignees
@Adam-it
Labels
⭐ enhancement New feature or request 💪 good first issue Good for newcomers 👨‍💻work in progress I am working on it
Milestone
v4.X

Comments

@Adam-it
Copy link
Contributor

Adam-it commented Jun 30, 2024

🎯 Aim of the feature

We should hide some functionalities of the toolkit that require the user to be logged in when we are not signed in to the tenant

image

also, we should recheck if we have correct checks done and not signed in error handling for those features because it is still possible to run them using VS Coda command palette

image

📷 Images (if possible) with expected result

No response

🤔 Additional remarks or comments

This may be a bit tricky as the command views are registered once so what I would do is start without showing the commands that require auth and when logged in just refresh the views and show them.
Similar thing is already done with the appcatalog view
image
@Adam-it Adam-it added ⭐ enhancement New feature or request 💪 good first issue Good for newcomers 🙏 help wanted Open for contributors labels Jun 30, 2024
@Adam-it Adam-it added this to the v3.X milestone Jul 28, 2024
@Adam-it Adam-it modified the milestones: v3.X, v4.X Sep 8, 2024
@Adam-it Adam-it added 👨‍💻work in progress I am working on it and removed 🙏 help wanted Open for contributors labels Sep 23, 2024
@Adam-it Adam-it self-assigned this Sep 23, 2024
@Adam-it Adam-it mentioned this issue Sep 23, 2024
Merged
2 tasks
@Adam-it Adam-it linked a pull request Sep 23, 2024 that will close this issue
Hide toolkit features that require signed in. Closes: #263 #307
Merged
2 tasks
Adam-it added a commit that referenced this issue Sep 27, 2024
@Adam-it
Hide toolkit features that require signed in. Closes: #263 (#307)
00454de 
## 🎯 Aim

The aim is to hide actions that require being signed in and validate if
SPFx project in chat actions

## ✅ What was done

- [X] Adds check if signed it
- [X] Adds check if SPFx project

## 🔗 Related issue

Closes:  #263
@Adam-it Adam-it closed this as completed Sep 27, 2024
Adam-it added a commit that referenced this issue Sep 28, 2024
@Adam-it
Hide toolkit features that require signed in. Closes: #263 (#307)
b8822bb 
## 🎯 Aim

The aim is to hide actions that require being signed in and validate if
SPFx project in chat actions

## ✅ What was done

- [X] Adds check if signed it
- [X] Adds check if SPFx project

## 🔗 Related issue

Closes:  #263
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Adam-it Adam-it

Labels
⭐ enhancement New feature or request 💪 good first issue Good for newcomers 👨‍💻work in progress I am working on it
Projects
None yet
Milestone
v4.X
Development

Successfully merging a pull request may close this issue.

Hide toolkit features that require signed in. Closes: #263 Adam-it/vscode-viva
1 participant
@Adam-it