Input methods (e.g. Chinese) don't work on empty line

[danqing]

For languages that require an input method to enter, the first letter isn't picked up:

[dminkovsky]

Hi @danqing. Thank you for reporting this. Have you tried this on ProseMirror without use-prosemirror? For example, in the editor on the homepage: https://prosemirror.net/?

[danqing]

Yes I did - it worked fine on prosemirror's site. Thank you @dminkovsky !

[dminkovsky]

Thanks for confirming @danqing.

I would like to replicate this. Some more questions:

• The GIF looks like it was recorded on macOS using the CodeSandbox from the README?
• If I add Chinese in the keyboard settings and enable it, I will be able to enter characters as pinyin using the keyboard as you show in the GIF?
• When you say "input methods" do you mean this also happens for other forms of entry?
• Does this only happen on an empty line?
• Did you try this with iOS?

[danqing]

The GIF looks like it was recorded on macOS using the CodeSandbox from the README?

That's right.

If I add Chinese in the keyboard settings and enable it, I will be able to enter characters as pinyin using the keyboard as you show in the GIF?

Yup.

When you say "input methods" do you mean this also happens for other forms of entry?

I mean it also happens for other languages that require input methods (e.g. Japanese). But if you are just copy-pasting text, things work fine.

Does this only happen on an empty line?

Yes.

Did you try this with iOS?

iOS works fine.

[dminkovsky]

@danqing Cool. Pretty important for me to correct this behavior. Thanks again for reporting this.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[dminkovsky]

Hmm please ignore this. I thought I had configured this bot not to mark pinned issues stale.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[dakhipp]

Would you guys be interested in updating the Prosemirror deps, more specifically prosemirror-view? I think it would resolve this issue. It was mentioned here with a patch in v1.18.11. https://discuss.prosemirror.net/t/prosemirror-view-upgrade-caused-chinese-to-be-affected-by-decoration-widget-during-input/2452/7

It would also add better Android support as mentioned here. ProseMirror/prosemirror-view@1a3faa9

I can PR it if you want, but I was unsure how open to it you'd be.

[dminkovsky]

Hi Dakota, thanks a lot for posting this! That’s great to hear re: this bug and Android support. Certainly you can PR, but I’m not sure that’s necessary? The deps are peer dependencies and if I’m not mistaken you can set the view version to 1.18.1 in your package.json without issue? Ср, 28 июля 2021 г. в 11:58 PM, Dakota Hipp ***@***.***>:

…

Would you guys be interested in updating the Prosemirror deps, more specifically prosemirror-view? I think it would resolve this issue. It was mentioned here with a patch in v1.18.11. https://discuss.prosemirror.net/t/prosemirror-view-upgrade-caused-chinese-to-be-affected-by-decoration-widget-during-input/2452/7 It would also add better Android support as mentioned here. ***@***.*** <ProseMirror/prosemirror-view@1a3faa9> I can PR it if you want, but I was unsure how open to it you'd be. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#11 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABVMZP2HIEETFP5QR57BB3T2DGXDANCNFSM42YEYIFA> .

[dakhipp]

Yeah, good point. I wasn't seeing the expected updates which made me consider updating, but no need with peerDependencies. I'm still seeing the issue, but I think it may be specific to how I'm using it in a webview. I'll leave the comment though, maybe updating prosemirror-view can help the OP. Thanks for the library!

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[mmmulani]

Was running into this issue with a Japanese IME and found it to be caused by the dispatchTransaction/onChange loop. Solved it by manually calling updateState on the view like this:

import { ProseMirror, Handle } from "use-prosemirror";

function Editor(...) {
  const handleRef = useRef<Handle>(null);
  const [proseState, setProseState] = useState(() => EditorState.create(...));
  return (
    <ProseMirror
      ref={handleRef}
      state={proseState}
      onChange={(state) => {
        setProseState(state);
        handleRef.current?.view?.updateState(state);
      }}
    />
  );
}

possibly changing the API for onChange/dispatchTransaction to return the new state that can be imperatively set on the view could fix this issue.