Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Performance #277

Open
cyanxiao opened this issue May 7, 2022 · 4 comments
Open

Improve Performance #277

cyanxiao opened this issue May 7, 2022 · 4 comments

Comments

@cyanxiao
Copy link
Contributor

cyanxiao commented May 7, 2022 •
edited
Loading

section.doc is an extemely large DOM. It affects rendering time and readability. Maybe we can truncate it by section and load it into different pages (maybe visibility controlled by JS instead of real pages) just like many other documents?
@ai
Copy link
Member

ai commented May 7, 2022

We will not have full text search in this case

@cyanxiao
Copy link
Contributor Author

cyanxiao commented May 7, 2022

Would some libs like Fuse.js be helpful?

@ai
Copy link
Member

ai commented May 7, 2022

But Fuse.js is not simple in-browser search which everone knows

@cyanxiao
Copy link
Contributor Author

cyanxiao commented May 7, 2022

Yes. But if the doc is going to be truncated and manipulated by JS, it's reasonable that the doc data can be used to implemented search function powered by Fuse.js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ai @cyanxiao