chore: address pr feedback

Signed-off-by: yHSJ <[email protected]>

Author: yHSJ

crates/amaru-ledger/src/rules.rs

@@ -94,6 +94,8 @@ pub fn validate_block(
         None => Vec::new(),
     };
 
+    // using `zip` here instead of enumerate as it is safer to cast from usize to u32 than u32 to usize
+    // Realistically, we're never gonna hit the u32 limit with the number of transactions in a block (a boy can dream)
     for (i, (transaction, raw_transaction)) in
         (0u32..).zip(transactions.iter().zip(raw_transactions))
     {

crates/amaru-ledger/src/rules/transaction/disjoint_ref_inputs.rs

@@ -12,12 +12,6 @@ impl Into<TransactionRuleViolation> for NonDisjointRefInputs {
     }
 }
 
-// impl From<NonDisjointRefInputs> for TransactionRuleViolation {
-//     fn from(value: NonDisjointRefInputs) -> Self {
-//         TransactionRuleViolation::NonDisjointRefInputs(value)
-//     }
-// }
-
 pub fn disjoint_ref_inputs(transaction: &TransactionBody) -> Result<(), NonDisjointRefInputs> {
     let intersection = match &transaction.reference_inputs {
         Some(ref_inputs) => ref_inputs

crates/amaru-ledger/src/rules/transaction/output_size.rs

@@ -6,7 +6,7 @@ use amaru_kernel::{
 use crate::rules::TransactionRuleViolation;
 
 pub struct OutputTooSmall {
-    pub outputs_too_small: Vec<TransactionOutput>,
+    pub outputs_too_small: Vec<&TransactionOutput>,
 }
 
 impl Into<TransactionRuleViolation> for OutputTooSmall {
@@ -22,9 +22,8 @@ pub fn validate_output_size(
 ) -> Result<(), OutputTooSmall> {
     let coins_per_utxo_byte = protocol_parameters.coins_per_utxo_byte;
     let outputs_too_small = transaction
-        .clone()
         .outputs
-        .into_iter()
+        .iter()
         .filter(|output| {
             let mut bytes = Vec::new();
             cbor::encode(output, &mut bytes)