-
-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use preact
and preact-router
from source instead of dist
#636
Comments
Thumbs down |
no? because? |
Preact & Router are super optimized distributions. No user-settings are going to match it. /cc @developit |
Now thats a thing I never knew, super interested in learning what is it? |
Follow here. IIRC it's circa ~1kb savings. This is actually (can) happen often, and is part of the reason why bundling from |
feel free to close :), if there's no better solution |
@developit We spoke about moving the optimizations to build size into Perhaps now is the time, or |
I'd support that 👍 It was a thumbs-down for present situation. My original intention for CLI was to extract some of the config into standalone chunks. I finally got around to the Babel stuff (#639), but an |
Another thing we can consider here is applying the Preact's minification processes to a bundled JS Modules version - with constant inlining, hoisting and a customized terser config I'm sure it'd be reasonably close to what preact ships over the wire today. |
Do you want to request a feature or report a bug?
Bug
What is the current behaviour?
We use
preact
andpreact-router
from their dist folder on npmWhat is the expected behaviour?
Since we transpile
node_modules
ourselves we should be usingpreact
andpreact_router
from their source. This will have no affect on the regular bundles but will have some saving on the module bundle generated.If this is a feature request, what is motivation or use case for changing the behaviour?
Web perf
Please mention other relevant information.
The text was updated successfully, but these errors were encountered: