Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http siteurl on https site will break widget #5

Open
pc-coholic opened this issue Jan 7, 2025 · 1 comment · May be fixed by #6
Open

http siteurl on https site will break widget #5

pc-coholic opened this issue Jan 7, 2025 · 1 comment · May be fixed by #6

Comments

@pc-coholic
Copy link
Member

pc-coholic commented Jan 7, 2025

If a wordpress' siteurl is set to http://foo.bar, the pretix-widget will not be properly display in the frontend only due to mixed content loading issues.

The fix is easy enough (unless the site owner is using wp_multisite) by going to /wp-admin/options-general.php and updating the siteurl to the proper https-version.

But I do still feel like there is something weird going on and we should have a look at this...

Everything else that is piped through the likes of wp_enqueue_script seems to properly detect that the script is running on an https-page; even when siteurl is set to http (such as wp-content/plugins/pretix-widget/assets/css/style.css) - it seems to only/mostly (?) affect the wp-content/uploads/pretix-widget/cache/randomhash.js...

cf. Z#23177854

@pc-coholic
Copy link
Member Author

Correction: This affects at least pretix-widget-frontend-css and pretix-widget-frontend-js.

pc-coholic added a commit that referenced this issue Jan 7, 2025
@pc-coholic pc-coholic linked a pull request Jan 7, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant