Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listbox: Nora Theme - Checkboxes should have different border color #17397

Open
1 of 4 tasks
can-oezkan opened this issue Jan 15, 2025 · 0 comments
Open
1 of 4 tasks

Listbox: Nora Theme - Checkboxes should have different border color #17397

can-oezkan opened this issue Jan 15, 2025 · 0 comments
Assignees
Labels
Component: Theme Issue or pull request is related to Theme Status: Pending Review Issue or pull request is being reviewed by Core Team
Milestone

Comments

@can-oezkan
Copy link
Contributor

can-oezkan commented Jan 15, 2025

Describe the bug

When using the Nora Theme, the checkboxes inside listbox should have a different border color.

Image

The desired look can be achieved by setting the css variable to primary contrast:

--p-checkbox-checked-border-color: var(--p-primary-contrast-color);

Pull Request Link

No response

Reason for not contributing a PR

  • Lack of time
  • Unsure how to implement the fix/feature
  • Difficulty understanding the codebase
  • Other

Other Reason

No response

Reproducer

https://stackblitz.com/edit/github-42xhqeeh?file=src%2Fapp%2Fapp.component.html

Environment

stackblitz

Angular version

19

PrimeNG version

v19

Node version

No response

Browser(s)

No response

Steps to reproduce the behavior

  1. Use listbox with checkboxes enabled
  2. select items
  3. border color should be different from background color.

Expected behavior

border color should be white:

Image

@can-oezkan can-oezkan added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 15, 2025
@can-oezkan can-oezkan changed the title Listbox: Nora Theme - Ceckboxes should have different border color Listbox: Nora Theme - Checkboxes should have different border color Jan 15, 2025
@mertsincan mertsincan added Status: Pending Review Issue or pull request is being reviewed by Core Team Component: Theme Issue or pull request is related to Theme and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 16, 2025
@mertsincan mertsincan added this to the 19.1.0 milestone Jan 16, 2025
@github-project-automation github-project-automation bot moved this to Review in PrimeNG Jan 16, 2025
@mertsincan mertsincan moved this from Review to Theme in PrimeNG Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Theme Issue or pull request is related to Theme Status: Pending Review Issue or pull request is being reviewed by Core Team
Projects
Status: Theme
Development

No branches or pull requests

3 participants