Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Templates and headers in pick list do not work #17413

Open
4 tasks
DaSchTour opened this issue Jan 16, 2025 · 2 comments · May be fixed by #17412
Open
4 tasks

Templates and headers in pick list do not work #17413

DaSchTour opened this issue Jan 16, 2025 · 2 comments · May be fixed by #17412
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Milestone
19.1.0

Comments

@DaSchTour
Copy link
Contributor

DaSchTour commented Jan 16, 2025 •
edited
Loading

Describe the bug

Templates and headers in picklist are not correctly passed to listbox

Pull Request Link

#17412

Reason for not contributing a PR

  • Lack of time
  • Unsure how to implement the fix/feature
  • Difficulty understanding the codebase
  • Other

Other Reason

No response

Reproducer

https://stackblitz.com/~/github.com/DaSchTour/primeng-bugs

Environment

Stackblitz, See above

Angular version

19.0

PrimeNG version

v19

Node version

No response

Browser(s)

No response

Steps to reproduce the behavior

Use templates in picklist

Expected behavior

Templates are not used/displayed
@DaSchTour DaSchTour added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 16, 2025
@mertsincan mertsincan added this to the 19.1.0 milestone Jan 17, 2025
@github-project-automation github-project-automation bot moved this to Review in PrimeNG Jan 17, 2025
@mertsincan mertsincan added Status: Pending Review Issue or pull request is being reviewed by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 17, 2025
@dhuome
Copy link

dhuome commented Jan 21, 2025

If I’m not mistaken, this happens because you’re using the old templating method. PrimeNG 19 changed the way templates are defined to align with Angular 19.

@DaSchTour
Copy link
Contributor Author

From what I have seen in the code both should work but are not correctly passed into the listbox component.

@DaSchTour DaSchTour linked a pull request Jan 29, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Projects
PrimeNG
Status: Review
Milestone
19.1.0
Development

Successfully merging a pull request may close this issue.

fix: picklist templates DaSchTour/primeng
3 participants
@DaSchTour @mertsincan @dhuome